codewithdaniel1 commented on PR #42625: URL: https://github.com/apache/superset/pull/42625#issuecomment-5245220113
Thanks for the reviews on this. I noticed #42752 was merged to address #33206. Since this PR had independently identified the same SQLAlchemy first-element bind-type issue and takes a slightly different approach by reordering the mixed numeric values rather than coercing integers to floats, should I close this PR as superseded? I also noticed the large-integer precision concern raised on #42752. This implementation preserves the original integer values, so if that remains a concern after the merged fix, I'm happy to adapt the regression coverage or rework this PR into a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
