Copilot commented on code in PR #43025:
URL: https://github.com/apache/superset/pull/43025#discussion_r3754046285
##########
tests/unit_tests/views/test_utils.py:
##########
@@ -51,3 +57,77 @@ def test_get_form_data_handles_non_dict_json_body() -> None:
assert form_data == {}
assert slc is None
+
+
+def test_get_dashboard_extra_filters_ignores_native_filter_defaults(
Review Comment:
Test name reads like it asserts the *current* buggy behavior ("ignores"),
but the docstring + assertion are expressing the desired behavior (native
filter defaults should be included). Renaming to reflect the expected behavior
will make the failure mode clearer once the fix is implemented.
This issue also appears on line 126 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
