rusackas commented on code in PR #43025:
URL: https://github.com/apache/superset/pull/43025#discussion_r3754681078


##########
tests/unit_tests/views/test_utils.py:
##########
@@ -51,3 +57,77 @@ def test_get_form_data_handles_non_dict_json_body() -> None:
 
     assert form_data == {}
     assert slc is None
+
+
+def test_get_dashboard_extra_filters_ignores_native_filter_defaults(

Review Comment:
   Fair point — renamed to 
`test_get_dashboard_extra_filters_includes_native_filter_defaults` to match the 
assertion, which expects defaults to be included.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to