rusackas commented on PR #36076: URL: https://github.com/apache/superset/pull/36076#issuecomment-5248417331
Looking better after the rebase. Still stuck on the layer question from before, though: this only validates the chart API, and #35774's report is mostly about native filters living in the dashboard's `json_metadata`, which never goes through here. @betodealmeida hasn't had a chance to weigh in after a few pings, so @michael-s-molina or @villebro, does either of you have a read on whether save-time validation is the right fix, or if this needs to happen at generation time instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
