rusackas commented on PR #39857: URL: https://github.com/apache/superset/pull/39857#issuecomment-5259072391
Following up here since it's been a couple weeks. test-sqlite is still red, and the two bugs I flagged are still in the diff: `overwrite=False` is hardcoded when importing annotation layers from both the chart and dashboard importers, so re-importing with overwrite on never actually updates them. The `_seen` circular-reference guard in `superset/commands/chart/export.py` doesn't survive the nested `ExportChartsCommand(...).run()` calls, so two charts referencing each other's annotations can still recurse forever. There's also a long list of open codeant/bito threads (dispatcher silently no-ops when no importer version matches, mutable default list in the annotation schema, integer-valued legacy annotation references getting dropped on import) worth triaging. @MallikarjunaReddyN any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
