rusackas commented on PR #42934:
URL: https://github.com/apache/superset/pull/42934#issuecomment-5259494999
Thanks @sha174n, appreciate the close read. Fixed 1 and 2:
`SupersetUserApi.pre_update` now stamps the epoch when `data.get("password")`
is set, and a falsy `password` gets popped before it reaches `UserDAO.update`'s
`setattr` loop.
On 3, I'm inclined to leave it as is. Most users don't have a
`user_attribute` row until this (or another lazy attribute) creates one, so a
pre-check `SELECT` would add a round trip to the common first-stamp case just
to save one in the rarer already-fresh race. Feels like a wash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
