sha174n commented on PR #42934: URL: https://github.com/apache/superset/pull/42934#issuecomment-5331241868
Rechecked the latest push — the admin-path epoch stamp (`SupersetUserApi.pre_update`) and the falsy-password drop in `CurrentUserRestApi.pre_update` both look good, and the `current_password` proof + no-password-yet exemption read cleanly. Nicely tested too. One non-blocking behavior note: `_login_at` is only written at login and isn't refreshed after a self password change, so when a user changes their own password the epoch is stamped to `now` and the `before_request` hook then logs the actor out on the next request — not just their other sessions. That's fail-safe (it over-logs-out rather than under), so it's a UX call rather than a correctness issue; forcing re-login after a password change is a defensible posture. If you'd prefer to keep the acting session alive and only revoke the siblings, note that the epoch is `ceil(now)`, so the current session's `_login_at` would need to be re-stamped to at least the epoch value — a plain `utcnow()` would still compare as invalidated. Fine to leave for a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
