rusackas commented on PR #42929: URL: https://github.com/apache/superset/pull/42929#issuecomment-5260026606
@sha174n thanks for the read-through. Rebased over #42936 and dropped the duplicate database-access check it added in `_validate_dataset_source` - the existing `_validate_sql_access`/physical-repoint checks already covered repointing, so the two were double-calling `raise_for_access` and breaking #42936's own tests. On the fail-closed question: yes, intentional. `validate_rendered_expression` only runs on Jinja output rendered at request time, so failing closed there is the safer default. The fallback in the stored-expression check exists for legacy dialect-specific syntax already sitting in the DB, which doesn't apply to freshly rendered SQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
