bito-code-review[bot] commented on code in PR #42929:
URL: https://github.com/apache/superset/pull/42929#discussion_r3764176393
##########
superset/models/helpers.py:
##########
@@ -329,6 +329,62 @@ def validate_stored_expression_at_query_time(
return expression
+def validate_rendered_expression(
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to add unit tests for
`validate_rendered_expression` is appropriate, as it ensures the new public
function is properly covered, matching the testing pattern used for
`validate_stored_expression_at_query_time`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
