aminghadersohi commented on PR #42659: URL: https://github.com/apache/superset/pull/42659#issuecomment-5272245021
Addressed the remaining review feedback in `44aa2569fa`: added request-schema validation coverage for both dashboard lookup schemas. I did not add the suggested `mock_permalink.assert_not_called()` in the layout precedence test because the stated premise is incorrect: when both fields are supplied, the explicit identifier selects the dashboard, but the permalink is intentionally resolved so its tab/filter state can be applied only when it belongs to that same dashboard. The existing mismatch test verifies that mismatched state is excluded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
