codeant-ai-for-open-source[bot] commented on code in PR #43129:
URL: https://github.com/apache/superset/pull/43129#discussion_r3777030604
##########
superset/mcp_service/dataset/tool/create_virtual_dataset.py:
##########
@@ -213,6 +214,17 @@ async def create_virtual_dataset(
url=None,
error=f"Failed to update dataset metadata (creation rolled back):
{exc}",
)
+ except SupersetGenericDBErrorException as exc:
+ await ctx.warning(f"Virtual dataset SQL failed validation: {exc}")
+ return CreateVirtualDatasetResponse(
+ id=None,
+ dataset_name=request.dataset_name,
+ sql=request.sql,
+ database_id=request.database_id,
+ columns=[],
+ url=None,
+ error=f"Dataset SQL could not be executed: {exc}",
Review Comment:
**Suggestion:** The response copies the raw exception text into the MCP
payload. The exception is populated from `str(ex)` for database-driver
failures, which can expose backend-specific diagnostics such as internal
relation names, SQL details, or connection-related information to MCP callers.
Return a sanitized actionable message while logging the detailed exception
server-side. [security]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ MCP responses may disclose warehouse diagnostics.
- โ ๏ธ Backend relation names can reach authorized callers.
- โ ๏ธ Driver-specific connection details may be exposed.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4a64ce4ab97c4f51a2de994256dfd0b8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4a64ce4ab97c4f51a2de994256dfd0b8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/dataset/tool/create_virtual_dataset.py
**Line:** 226:226
**Comment:**
*Security: The response copies the raw exception text into the MCP
payload. The exception is populated from `str(ex)` for database-driver
failures, which can expose backend-specific diagnostics such as internal
relation names, SQL details, or connection-related information to MCP callers.
Return a sanitized actionable message while logging the detailed exception
server-side.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43129&comment_hash=8b740d510fcdb98de72fab4c842d07a7fc0847e4dba8735e9e92e9fe5dd42c09&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43129&comment_hash=8b740d510fcdb98de72fab4c842d07a7fc0847e4dba8735e9e92e9fe5dd42c09&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
