codeant-ai-for-open-source[bot] commented on code in PR #43110:
URL: https://github.com/apache/superset/pull/43110#discussion_r3781865635
##########
superset/db_engine_specs/__init__.py:
##########
@@ -165,7 +165,24 @@ def get_available_engine_specs() ->
dict[type[BaseEngineSpec], set[str]]: # noq
except Exception as ex: # pylint: disable=broad-except
logger.debug("Unable to load SQLAlchemy dialect %s: %s", ep.name,
ex)
else:
- backend = dialect.name
+ # A third-party entry point can load successfully yet not resolve
to
+ # a usable dialect -- e.g. a malformed ``name = pkg:module`` entry
+ # point yields a module, which has no ``name``. Reading ``.name``
+ # unguarded here would raise and abort the whole enumeration,
taking
+ # down every page that builds the bootstrap payload rather than
just
+ # marking that one connector unavailable. Skip it with a warning
+ # instead, mirroring the defensiveness of the native-dialect loop
+ # above.
+ backend = getattr(dialect, "name", None)
+ if not isinstance(backend, (str, bytes)):
+ logger.warning(
+ "Skipping SQLAlchemy dialect entry point %r: %r did not "
+ "resolve to a usable dialect (%r)",
+ ep.name,
+ ep.value,
+ dialect,
+ )
+ continue
Review Comment:
**Suggestion:** The guard only checks that the loaded object exposes a
string or bytes `name`; it does not verify that the object is a SQLAlchemy
dialect class or implements the dialect contract. A malformed entry point that
exposes a plausible `name` (but lacks a working `driver` or `dbapi()`
implementation) will still be added to `drivers` and later advertised by the
database API as an available connector, even though connections using it cannot
work. Validate the loaded object against the same usable-dialect requirements
as the native-dialect path before registering it. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Broken third-party connectors appear available.
- ⚠️ Database API advertises unusable drivers.
- ❌ Connection setup fails after connector selection.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=dab4c269fc404ca48acd0c7774a72f05&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=dab4c269fc404ca48acd0c7774a72f05&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/__init__.py
**Line:** 176:185
**Comment:**
*Api Mismatch: The guard only checks that the loaded object exposes a
string or bytes `name`; it does not verify that the object is a SQLAlchemy
dialect class or implements the dialect contract. A malformed entry point that
exposes a plausible `name` (but lacks a working `driver` or `dbapi()`
implementation) will still be added to `drivers` and later advertised by the
database API as an available connector, even though connections using it cannot
work. Validate the loaded object against the same usable-dialect requirements
as the native-dialect path before registering it.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43110&comment_hash=1a2abe048b08a5bc5a5f29022e0d939c5d79a498bce795249df51eeb7b411a06&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43110&comment_hash=1a2abe048b08a5bc5a5f29022e0d939c5d79a498bce795249df51eeb7b411a06&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
