alexandrusoare commented on issue #42798: URL: https://github.com/apache/superset/issues/42798#issuecomment-5291593088
Thank you for your proposal and your work! Just a few thoughts: Subject model alignment: The PR introduces a dashboard_folder_user owner association table, but Superset has recently moved to a Subject-based model with separate editor/viewer relationships (see the subjects, dashboard_editors, dashboard_viewers tables). Any new entity with user associations should adopt that pattern for consistency rather than introducing another legacy-style owner table that will need to be migrated later. Extension architecture (SIP-219): SIP-219 is actively defining how new surfaces and features should be built in Superset — as extensions with a uniform registration and resolution model. The dashboard list is one of the core surfaces being considered for this treatment. A folder navigation panel is a natural augmentable contribution point for the dashboard list surface. Hardcoding it into core now creates exactly the pattern SIP-219 is working to eliminate. It might be worth tagging this as an extension-candidate and aligning the implementation with the extension architecture once SIP-219 lands, so the folder panel can be properly registered and resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
