coreforge196 commented on issue #42798: URL: https://github.com/apache/superset/issues/42798#issuecomment-5301191821
Thanks for the detailed feedback — both points make sense. On the subject model alignment, I agree that introducing another legacy-style ownership association such as dashboard_folder_user would be the wrong direction if Superset has already standardized on the subject-based model with separate editor/viewer relationships. I’ll revisit this part and align folder permissions with the existing subject/editor/viewer pattern rather than introducing a new ownership model that would require another migration later. I also agree with the SIP-219 point. Folder navigation feels more like a contribution to the dashboard list surface than something that should be permanently hard-coded into core. The current implementation was mainly intended to validate the folder UX and the underlying data model, but architecturally it makes sense to keep the UI integration decoupled and treat the folder panel as an extension candidate. My proposed direction would be to: 1. Remove the dashboard_folder_user ownership-style relationship and align permissions with the current subject/editor/viewer model. 2. Decouple the folder data model/API from the dashboard-list UI integration. 3. Avoid baking the folder navigation panel deeply into the dashboard list surface. 4. Integrate it through the SIP-219 extension registration/resolution mechanism once that contract is available. This should allow us to move the folder capability forward without introducing another legacy permission pattern or locking the dashboard list into an integration model that SIP-219 is intended to replace. If this direction matches what you have in mind, I’ll update the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
