codeant-ai-for-open-source[bot] commented on code in PR #43182:
URL: https://github.com/apache/superset/pull/43182#discussion_r3786709722
##########
Dockerfile:
##########
@@ -194,14 +194,17 @@ COPY scripts/check-env.py scripts/
# keeping for backward compatibility
COPY --chmod=755 ./docker/entrypoints/run-server.sh /usr/bin/
-# Some debian libs
+# Some debian libs. Only runtime shared libraries belong here: the matching
+# `-dev` packages drag in a full C toolchain (libc6-dev, linux-libc-dev,
+# libssl-dev, ...) that no final image needs. Stages that compile native Python
+# extensions install the headers they require themselves.
RUN /app/docker/apt-install.sh \
curl \
- libsasl2-dev \
+ libsasl2-2 \
libsasl2-modules-gssapi-mit \
- libpq-dev \
- libecpg-dev \
- libldap2-dev
+ libpq5 \
+ libecpg6 \
+ libldap2
Review Comment:
**Suggestion:** The Debian trixie runtime package is versioned
`libldap-2.6-0`, not `libldap2`. Since `apt-install.sh` passes package names
directly to `apt-get install` without fallback, this causes the `python-common`
stage and every descendant image to fail during construction. Replace it with
the runtime package name provided by the selected Debian release. [api mismatch]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ `python-common` cannot build on Debian trixie.
- ❌ Lean and development images cannot be produced.
- ❌ Docker-based deployment and CI builds fail.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1c131bb1fd5c4920a0c027003a8fda82&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1c131bb1fd5c4920a0c027003a8fda82&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** Dockerfile
**Line:** 207:207
**Comment:**
*Api Mismatch: The Debian trixie runtime package is versioned
`libldap-2.6-0`, not `libldap2`. Since `apt-install.sh` passes package names
directly to `apt-get install` without fallback, this causes the `python-common`
stage and every descendant image to fail during construction. Replace it with
the runtime package name provided by the selected Debian release.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43182&comment_hash=f6b359ef3b62d4dd6fa85fb76341a29e8f00273117e5ff580bebd4a7cd4371a1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43182&comment_hash=f6b359ef3b62d4dd6fa85fb76341a29e8f00273117e5ff580bebd4a7cd4371a1&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
