Copilot commented on code in PR #43182: URL: https://github.com/apache/superset/pull/43182#discussion_r3797513641
########## Dockerfile: ########## @@ -194,14 +194,17 @@ COPY scripts/check-env.py scripts/ # keeping for backward compatibility COPY --chmod=755 ./docker/entrypoints/run-server.sh /usr/bin/ -# Some debian libs +# Some debian libs. Only runtime shared libraries belong here: the matching +# `-dev` packages drag in a full C toolchain (libc6-dev, linux-libc-dev, +# libssl-dev, ...) that no final image needs. Stages that compile native Python +# extensions install the headers they require themselves. Review Comment: The comment says the `-dev` packages "drag in a full C toolchain", but this stage does not install/retain compilers (and `pip-install.sh` already installs/purges `build-essential`). To avoid misleading future readers, describe these as development headers/build-time deps rather than a toolchain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
