bito-code-review[bot] commented on PR #43205:
URL: https://github.com/apache/superset/pull/43205#issuecomment-5300579282
<!-- Bito Reply -->
The flagged issue is correct. The `PROPHET_TIME_GRAIN_MAP` in
`superset/utils/pandas_postprocessing/utils.py` was missing mappings for
several time grains, which caused `prophet()` to fail when encountering them,
despite them being valid according to the schema. The provided PR diff already
includes a fix by adding these missing mappings to `PROPHET_TIME_GRAIN_MAP` and
adding unit tests to ensure all `TimeGrain` values are covered.
Since the fix is already implemented in the PR, no further action is
required for this specific comment.
**superset/utils/pandas_postprocessing/utils.py**
```
PROPHET_TIME_GRAIN_MAP: dict[str, str] = {
TimeGrain.SECOND: "s",
+ TimeGrain.FIVE_SECONDS: "5s",
+ TimeGrain.THIRTY_SECONDS: "30s",
TimeGrain.MINUTE: "min",
TimeGrain.FIVE_MINUTES: "5min",
TimeGrain.TEN_MINUTES: "10min",
TimeGrain.FIFTEEN_MINUTES: "15min",
TimeGrain.THIRTY_MINUTES: "30min",
+ # An alternate ISO-8601 spelling of THIRTY_MINUTES that a number of
engine
+ # specs expose instead; the two denote the same interval.
+ TimeGrain.HALF_HOUR: "30min",
TimeGrain.HOUR: "h",
+ TimeGrain.SIX_HOURS: "6h",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
