SEPURI-SAI-KRISHNA commented on code in PR #43205:
URL: https://github.com/apache/superset/pull/43205#discussion_r3788672001
##########
superset/utils/pandas_postprocessing/utils.py:
##########
@@ -86,16 +86,24 @@
PROPHET_TIME_GRAIN_MAP: dict[str, str] = {
Review Comment:
Correct, and pre-existing, get_time_grain_choices() merges
TIME_GRAIN_ADDONS, so operator-defined grains are advertised but unmapped. That
can't be fixed by extending a static map, since addon keys are arbitrary
ISO-8601 durations; it needs a general duration→pandas-frequency converter. Out
of scope here, where the concern is the built-in grains Superset ships and
engine specs already offer. Happy to open a follow-up issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
