kakoni opened a new pull request, #43253:
URL: https://github.com/apache/superset/pull/43253
### SUMMARY
`MachineAuthProvider.authenticate_browser_context()` calls
`page.goto(headless_url("/login/"))`
without `wait_until`, so Playwright falls back to its `load` default. In
deployments where
`/login/` reaches `domcontentloaded` but never fires `load`, machine auth
times out and the
report never gets to the screenshot step, even though the rest of the
Playwright flow already
honors `SCREENSHOT_PLAYWRIGHT_WAIT_EVENT`.
This passes that config through to the auth navigation, making it consistent
with the rest of
the screenshot flow. The default (`domcontentloaded`) resolves the timeout
while staying
configurable.
### TESTING INSTRUCTIONS
Against a deployment where `/login/` never completes `load`:
- `page.goto(url, wait_until="load", timeout=60000)` times out
- `page.goto(url, wait_until="domcontentloaded", timeout=60000)` succeeds
Before the change, triggering a report snapshot fails during machine auth
with
`Page.goto: Timeout 60000ms exceeded ... waiting until "load"`. After,
navigation completes and
the report proceeds. Also verified that setting the config to another
supported Playwright event
is respected by the auth navigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
