bito-code-review[bot] commented on PR #43253:
URL: https://github.com/apache/superset/pull/43253#issuecomment-5314864999
<!-- Bito Reply -->
The flagged issue is correct. The `page.goto` call lacks a timeout handler,
which causes the authentication process to abort if the configured event (e.g.,
`networkidle`) takes longer than the default Playwright timeout. To resolve
this, wrap the navigation in a `try-except` block to catch
`playwright.sync_api.TimeoutError` and proceed with cookie installation
regardless of the navigation timeout.
**superset/utils/machine_auth.py**
```
try:
page.goto(
headless_url("/login/"),
wait_until=app.config["SCREENSHOT_PLAYWRIGHT_WAIT_EVENT"],
)
except Exception:
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
