DeepFriedYeti commented on code in PR #40954:
URL: https://github.com/apache/superset/pull/40954#discussion_r3806529550
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts:
##########
@@ -32,6 +32,7 @@ import {
isTimeComparison,
pivotOperator,
prophetOperator,
+ anomalyDetectionOperator,
Review Comment:
This doesn't cause a failure, anomalyDetectionOperator returns undefined
unless formData.anomalyDetectionEnabled is set, which neither test fixture in
this file sets (same pattern as prophetOperator one line above it, already in
the array). buildQueryContext.ts runs post_processing.filter on the final array
before returning it, so the disabled operator is stripped before these
assertions ever see it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
