bito-code-review[bot] commented on code in PR #40954:
URL: https://github.com/apache/superset/pull/40954#discussion_r3816260177
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts:
##########
@@ -64,6 +64,14 @@ export type EchartsTimeseriesFormData = QueryFormData & {
forecastSeasonalityDaily: null;
forecastSeasonalityWeekly: null;
forecastSeasonalityYearly: null;
+ anomalyDetectionEnabled: boolean;
+ anomalyDetectionMethod: string;
+ anomalyDetectionRollingWindow: number;
+ anomalyDetectionSensitivity: number;
+ anomalyDetectionConfidenceInterval: number;
+ anomalyDetectionSeasonalityYearly: null | boolean | number;
+ anomalyDetectionSeasonalityWeekly: null | boolean | number;
+ anomalyDetectionSeasonalityDaily: null | boolean | number;
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate to apply. Aligning the types for the anomaly
detection seasonality properties with the existing forecast seasonality
properties ensures consistency across the codebase, as both sets of properties
utilize the same UI controls and validation logic.
**superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts**
```
anomalyDetectionSeasonalityYearly: null | boolean | number;
anomalyDetectionSeasonalityWeekly: null | boolean | number;
anomalyDetectionSeasonalityDaily: null | boolean | number;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
