bito-code-review[bot] commented on PR #43308:
URL: https://github.com/apache/superset/pull/43308#issuecomment-5337245635
<!-- Bito Reply -->
The suggestion to reword the comment or use a generic metric name like `'m'`
is appropriate. Using `'SUM(sales)'` in the test code can indeed be misleading,
as it implies an additive metric, whereas the test is specifically validating
behavior for non-additive metrics (where the rollup levels are included in the
query result). Updating the test to use a more generic identifier would better
align the test code with the intent of the comment and the behavior being
verified.
**superset-frontend/plugins/plugin-chart-pivot-table/test/plugin/transformProps.test.ts**
```
// A saved-metric reference is non-additive, so buildQuery issues a single
// GROUPING SETS query whose result carries the rollup levels alongside the
// leaf rows. Both totals toggles are on, so the grand total (100) is part
of
// that result.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
