bito-code-review[bot] commented on PR #43481:
URL: https://github.com/apache/superset/pull/43481#issuecomment-5399508861
<!-- Bito Reply -->
The flagged issue is correct. The current implementation filters the domain
for conditional formatting to include only leaf rows, which prevents subtotals
from skewing the color scale, but it inadvertently causes subtotals to lose
their conditional formatting because they are no longer part of the domain used
by `getCellColor`.
To resolve this, you should include the rendered subtotal values in the
domain while ensuring they do not influence the detail scale. This can be
achieved by calculating the color scale based only on leaf rows, but allowing
the `getCellColor` function to evaluate subtotals against that established
scale.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/transformProps.ts**
```
const metricColorFormatters = getColorFormatters(
pivotConditionalFormatting,
colorScaleRows,
theme,
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
