AurimasNav commented on PR #43329: URL: https://github.com/apache/superset/pull/43329#issuecomment-5351357933
Pushed `028f5ee`, which fixes the cause of the 0% patch coverage rather than just explaining it — so the report on this PR should now show the new lines as covered. **The bug.** `unit-tests` runs the full suite under `--cov=superset`, then two scoped gates under `--cov=superset/sql/` and `--cov=superset/semantic_layers/`. pytest-cov starts a fresh data file per run and none of these pass `--cov-append`, so each gate *replaces* `.coverage`. By the time the codecov step converts it, the report holds only the `semantic_layers` subtree — so every file outside those two trees uploads as uncovered, and patch coverage reads 0% on any PR touching the rest of the codebase, however well tested. That is not specific to this PR; it affects every PR outside `superset/sql/` and `superset/semantic_layers/`. **Reproduced locally**, on this branch: | Step | `superset/mcp_service/server.py` in `coverage.xml` | |---|---| | after `--cov=superset` run | present | | after `--cov=superset/semantic_layers/` gate | **gone** | | with `COVERAGE_FILE` set on the gate | present, 141 of 395 lines measured | **The fix.** Point the gates at `COVERAGE_FILE` under `RUNNER_TEMP` so the full-suite data survives for the upload. Under `RUNNER_TEMP` rather than the workspace so codecov's file search cannot pick the data files up as reports of their own. Verified the gates still enforce 100% over their own subtree — that behaviour is unchanged. Happy to split this into its own PR if maintainers would rather keep the fix and the CI change separate; it is here because it is what makes this PR's coverage report readable. For the record on the earlier report: the three new tests did run and pass in CI all along — they are in `junit-unit.xml` in the `junit-results-current` artifact of run 32229167129. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
