sha174n commented on PR #43329: URL: https://github.com/apache/superset/pull/43329#issuecomment-5368860097
LGTM. The custom MCP_AUTH_FACTORY branch now mirrors the default-factory branch: a factory that raises surfaces as MCPAuthConfigError and propagates out of _create_auth_provider so the service does not come up in an unintended state, and I confirmed the caller does not catch it. Good touch keeping only the exception type name and dropping the original with 'from None'. The one red check is the unrelated translations extraction gate (this PR touches no strings), so a re-run should clear it to unblock merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
