sadpandajoe commented on code in PR #43199:
URL: https://github.com/apache/superset/pull/43199#discussion_r3818928276
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -2417,6 +2417,16 @@ function DatasourceEditor({
filterTerm={columnSearchTerm}
filterFields={['column_name']}
onColumnsChange={cols => setColumns({ databaseColumns: cols })}
+ columnLabelTooltips={{
+ is_dttm: t(
+ 'Marks the column as a time column, so it can drive the ' +
+ 'time range filter and time grain. A column whose database
' +
+ 'type is not already a date or timestamp also needs a ' +
+ 'Datetime format below, otherwise a time grain builds SQL
' +
+ 'such as DATE_TRUNC() directly against the raw column and
' +
+ 'the query fails.',
+ ),
Review Comment:
Agreed—the Datetime format does not transform an ordinary string column, so
following this guidance can still leave a time grain applied to raw text or
return incorrect results. Could this point users to a casting/calculated-column
expression and avoid promising that the format resolves the failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
