sadpandajoe commented on code in PR #43199:
URL: https://github.com/apache/superset/pull/43199#discussion_r3871071600
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -2417,6 +2417,16 @@ function DatasourceEditor({
filterTerm={columnSearchTerm}
filterFields={['column_name']}
onColumnsChange={cols => setColumns({ databaseColumns: cols })}
+ columnLabelTooltips={{
Review Comment:
Keyboard users cannot access this new guidance: the shared tooltip opens on
hover, while activating its control can fall through to this sortable header.
Could this use a focus/click-accessible disclosure and stop the event from
sorting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
