sadpandajoe commented on code in PR #43085:
URL: https://github.com/apache/superset/pull/43085#discussion_r3819384345
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -157,20 +181,26 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug
}: PageProps) => {
const isNotFoundError = (error as SupersetApiError | null)?.status === 404;
const readyToRender = Boolean(dashboard && charts);
const { dashboard_title, id = 0 } = dashboard || {};
+ const hydratedDashboardId = useSelector<RootState, number | undefined>(
+ state => state.dashboardInfo?.id,
+ );
+ const fullDataMask = useSelector(selectDataMask);
+ useEffect(() => {
+ if (!id || hydratedDashboardId !== id) return;
+ saveDashboardFilters(id, fullDataMask);
+ }, [id, hydratedDashboardId, fullDataMask]);
Review Comment:
Agreed—the unmount path clears `dataMask` while `dashboardInfo` still
identifies this dashboard, so this effect writes `{}` before the restore branch
reads the previous selection. Could persistence wait until this load has
restored its initial mask?
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -226,6 +256,11 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
}
} else if (nativeFilterKeyValue) {
dataMask = await getFilterValue(id, nativeFilterKeyValue);
+ } else {
+ const savedFilters = getSavedDashboardFilters(id);
+ if (savedFilters) {
+ dataMask = savedFilters;
+ }
}
Review Comment:
Agreed—when navigation swaps the dashboard id while `readyToRender` remains
true, this effect does not run again, so the next dashboard never reads its own
stored mask. Could the hydration lifecycle be keyed or reset by dashboard
identity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
