sadpandajoe commented on code in PR #43085:
URL: https://github.com/apache/superset/pull/43085#discussion_r3819399797
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -226,6 +256,11 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
}
} else if (nativeFilterKeyValue) {
dataMask = await getFilterValue(id, nativeFilterKeyValue);
+ } else {
+ const savedFilters = getSavedDashboardFilters(id);
+ if (savedFilters) {
+ dataMask = savedFilters;
+ }
Review Comment:
A saved mask is applied over the current filter defaults without checking
whether that filter’s targets changed. If an owner retargets an existing filter
ID (for example, from `country` to `region`), a returning user’s stored
`extraFormData` and selection can override the new configuration and query the
old column. Could this storage be invalidated or versioned against the
native-filter configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
