bito-code-review[bot] commented on PR #43268:
URL: https://github.com/apache/superset/pull/43268#issuecomment-5361183900
<!-- Bito Reply -->
The flagged issue is correct. The `display_name_for_viz_type()` function
currently iterates through all registered plugins to find a matching display
name without verifying if the plugin is available in the current deployment.
This allows the `interactive_pivot` display name to be returned even when the
feature is disabled.
To resolve this, you should update `display_name_for_viz_type` (or the
relevant lookup logic) to check `plugin.is_available()` before including the
plugin's display name in the results.
Would you like me to fetch all other comments on this PR to validate them
and implement a minimal fix for all of them?
**superset/mcp_service/chart/plugin.py**
```
def is_available(self) -> bool:
"""Return whether the host deployment provides this visualization."""
return True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
