aminghadersohi commented on code in PR #43268: URL: https://github.com/apache/superset/pull/43268#discussion_r3833547192
########## docs/docs/using-superset/using-ai-with-superset.mdx: ########## @@ -78,6 +78,16 @@ Charts are **not saved by default**. The workflow is intentionally iterative: To skip the preview and save immediately, include "and save it" in your prompt. ::: +:::info Deployment-specific chart types +Use `get_chart_type_schema` before generating a chart to discover the types +available on your Superset instance. Some deployments expose additional +feature-gated visualizations. For example, a Preset instance with the AG Grid +pivot plugin enabled exposes `interactive_pivot`, which supports interactive +row groups, pivot columns, and totals. It is distinct from Review Comment: This suggestion conflates two different visualizations. The cited documentation is for AG Grid Interactive Table (`ag-grid-table`), while this adapter targets Preset Interactive Pivot (`ag-grid-pivot-table`). `time_grain` buckets temporal dimensions; it does not implement time comparison. The Interactive Pivot buildQuery/transform/control-panel path has no consumer for `time_compare` or `comparison_type`, which the blocking review verified. Restoring the claim would reintroduce the false-success behavior fixed in 895af43772. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
