sha174n commented on PR #42895: URL: https://github.com/apache/superset/pull/42895#issuecomment-5368859701
One non-blocking follow-up: the Custom SQL prefill for MEDIAN emits the Postgres PERCENTILE_CONT(0.5) WITHIN GROUP spelling (AdhocMetric.ts), so a user who switches a Simple MEDIAN metric to Custom SQL and saves gets an expression that DuckDB/Redshift (which use native MEDIAN(col)) may reject. Fine as a later refinement since Custom SQL is a raw-expression escape hatch, just flagging the cross-engine round-trip wart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
