rusackas commented on PR #42895:
URL: https://github.com/apache/superset/pull/42895#issuecomment-5287838111
@sha174n good catch. MariaDB, Aurora MySQL/PostgreSQL (and the Data API
variants), and TimescaleDB are wire- and SQL-compatible forks running the same
query engine, not a different one like CockroachDB/Greenplum/HANA, so I kept
them inheriting rather than resetting to `{}`. Added the same explicit test
coverage Redshift already has for this, plus a comment next to
`_extended_aggregations` explaining why.
Also added display labels for `STDDEV_SAMP`/`VAR_SAMP` in the metric
aggregate dropdown so it doesn't show the raw enum.
The `STDDEV`/`VARIANCE` keys in `utils/core.py` predate this PR and are
already unreachable by the regex in `get_metric_type_from_column` (it only
matches SUM/AVG/COUNT/MIN/MAX/FIRST/LAST/MEDIAN/STDDEV_SAMP/VAR_SAMP), so
that's pre-existing dead weight rather than something this PR introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
