sadpandajoe commented on code in PR #43388:
URL: https://github.com/apache/superset/pull/43388#discussion_r3832764384
##########
superset/mcp_service/mcp_config.py:
##########
@@ -322,6 +322,13 @@ class MCPAuthConfigError(ValueError):
# When enabled with MCP_STORE_CONFIG, uses Redis store.
MCP_CACHE_CONFIG: dict[str, Any] = {
"enabled": False, # Disabled by default
+ # Cache keys are method/tool + arguments only and cache hits are served
+ # ahead of per-request auth/RBAC, so a shared cache can return one
+ # caller's response to another. Response caching refuses to start
+ # unless this is explicitly set -- only appropriate when every request
+ # is guaranteed to come from the same principal (e.g. a single-user
+ # development deployment).
+ "dangerously_share_cache_across_principals": False,
Review Comment:
The new opt-in makes the documented cache setup stop enabling caching: the
examples above set only `MCP_CACHE_CONFIG["enabled"] = True`, but this remains
false and the middleware refuses to start. Could those examples include
`dangerously_share_cache_across_principals = True` (with its single-principal
warning), or point operators to the new requirement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
