rusackas commented on PR #43388: URL: https://github.com/apache/superset/pull/43388#issuecomment-5397962764
Rebased on master to clear the conflict (one real overlap in `_create_auth_provider`'s `MCP_AUTH_FACTORY` error handling, where master had independently picked up an equivalent fix in the meantime — kept master's more detailed exception-type-aware message and merged in the `auth_provider is None` check this branch adds, which master didn't have). Addressed the four open threads from @sadpandajoe and @sha174n: - **find_users**: email-shaped queries are now rejected outright via a schema validator before they reach the DB filter, instead of relying on the email-column exclusion alone (usernames are often email addresses under OAuth provisioning). Regression test added. - **Response caching**: `excluded_tools` now covers every tool with a side effect, derived from each tool's own `readOnlyHint` annotation rather than a hand-maintained list — the old list was missing 18 mutating tools, not just `restore_chart`/`restore_dashboard`. Added a test that enumerates the live tool registry and fails with the specific missing tool name(s) if this drifts again. - **MCP_DEV_USERNAME / MCP_AUTH_ENABLED docs**: split the README's combined example (which now fails to start) into separate dev-mode and production examples, fixed the env-var table, and added an UPDATING.md entry. - **restore_chart/restore_dashboard tests**: the "inaccessible object reads as not-found" tests now key their mock's return value on the actual `skip_base_filter` kwarg of each call instead of call order, so a regression that leaves the base filter skipped on the re-lookup fails the test instead of passing silently. All four threads replied to individually and resolved. Full `mcp_service` suite green (3542/3543; the one failure is a pre-existing, unrelated flaky FK-constraint issue in `test_mcp_e2e_smoke.py`, reproducible on master before this change). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
