bito-code-review[bot] commented on code in PR #42404:
URL: https://github.com/apache/superset/pull/42404#discussion_r3833347779
##########
superset/models/core.py:
##########
@@ -144,6 +144,12 @@ class Theme(AuditMixinNullable, ImportExportMixin, Model):
is_system_default = Column(Boolean, default=False, nullable=False)
is_system_dark = Column(Boolean, default=False, nullable=False)
+ editors = relationship(
+ "Subject",
+ secondary="theme_editors",
+ passive_deletes=True,
+ )
Review Comment:
<!-- Bito Reply -->
Your assessment is correct. SQLAlchemy's declarative system resolves
string-based relationship targets at mapper-configuration time, meaning an
explicit import of the `Subject` class is not required in `core.py` for this
relationship definition. The suggestion provided by the reviewer is a false
positive in this context.
**superset/models/core.py**
```
editors = relationship(
"Subject",
secondary="theme_editors",
passive_deletes=True,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
