bito-code-review[bot] commented on PR #43502: URL: https://github.com/apache/superset/pull/43502#issuecomment-5406223469
<!-- Bito Reply --> The flagged issue is correct. The current test likely only verifies the existence of a column specification without validating that the specific native type (e.g., `INTEGER`) is correctly mapped to the expected SQLAlchemy or generic type. To resolve this, you should update the test to assert the specific mapped type and generic type for the column. Since I do not have access to the file content of `tests/testcontainers/db_engine_specs/test_trino.py` in this environment, I cannot provide the exact code implementation. Please verify the test logic and add an assertion that checks the `type` attribute of the column object returned by `get_columns` against the expected SQLAlchemy type. Regarding other comments on this PR, I have checked the available review data and found no other comments to address. If you have additional comments you would like me to review, please provide them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
