sadpandajoe commented on code in PR #43502:
URL: https://github.com/apache/superset/pull/43502#discussion_r3857462577
##########
pyproject.toml:
##########
@@ -142,7 +142,13 @@ bigquery = [
"google-cloud-bigquery>=3.42.3",
]
clickhouse = ["clickhouse-connect>=1.7.1, <2.0"]
-cockroachdb = ["cockroachdb>=0.3.5, <0.4"]
+# The `cockroachdb` PyPI package (last released 2021) is abandoned and its
+# SQLAlchemy dialect cannot even import under SQLAlchemy 2.0 (it references
+# sqlalchemy.dialects.postgresql.psycopg2.PGCompiler_psycopg2, removed in
+# 2.0). sqlalchemy-cockroachdb is the actively maintained replacement,
+# already linked from CockroachDbEngineSpec.metadata's docs_url, and
+# registers the same `cockroachdb` SQLAlchemy dialect entry point.
+cockroachdb = ["sqlalchemy-cockroachdb>=2.0.0, <3"]
Review Comment:
Installing the documented `apache-superset[cockroachdb]` extra now installs
only the dialect, but that package declares no DBAPI dependency; its own docs
require `psycopg2`/`psycopg`/`asyncpg`. A fresh CockroachDB-only install
therefore reaches the new `cockroachdb://` URL without a usable driver and
cannot connect. Should this extra include a supported DBAPI (or the documented
install command include one)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
