bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5410177356
<!-- Bito Reply -->
The flagged issue is correct. In `transformProps.ts`, the `minInterval`
values for the X and Y axes are currently assigned directly from
`xAxisMinInterval` and `yAxisMinInterval` without considering the chart's
orientation. For horizontal bar charts, these should be swapped to ensure the
user-configured intervals align with the correct physical axes.
To resolve this, you should update the assignment logic in
`transformProps.ts` to check the `isHorizontal` flag and swap the parsed
interval values accordingly before applying them to the `xAxis` and `yAxis`
objects.
**superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts**
```
const parsedXAxisMinInterval = parseMinInterval(xAxisMinInterval);
const parsedYAxisMinInterval = parseMinInterval(yAxisMinInterval);
const xMinInterval = isHorizontal ? parsedYAxisMinInterval :
parsedXAxisMinInterval;
const yMinInterval = isHorizontal ? parsedXAxisMinInterval :
parsedYAxisMinInterval;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
