codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r3852799331
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -193,12 +195,14 @@ const config: ControlPanelConfig = {
],
[xAxisLabelRotation],
[xAxisLabelInterval],
+ [xAxisMinInterval],
Review Comment:
**Suggestion:** The X-axis minimum-interval control is added without a
visibility predicate, so it is displayed for categorical X axes even though the
control description says it only applies to numeric and time axes. Because
`transformProps` still maps the entered value to `xAxis.minInterval`, users can
save a setting that has no effect on categorical charts. Add visibility based
on the selected X-axis column type, consistent with the existing X-axis format
controls. [api mismatch]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Categorical Line Chart settings expose an ineffective control.
- โ ๏ธ Users may believe tick spacing changed when it did not.
- โ ๏ธ Inapplicable values remain persisted in chart form data.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5b90183ceb9b49549021a56ca9751b57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5b90183ceb9b49549021a56ca9751b57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx
**Line:** 198:198
**Comment:**
*Api Mismatch: The X-axis minimum-interval control is added without a
visibility predicate, so it is displayed for categorical X axes even though the
control description says it only applies to numeric and time axes. Because
`transformProps` still maps the entered value to `xAxis.minInterval`, users can
save a setting that has no effect on categorical charts. Add visibility based
on the selected X-axis column type, consistent with the existing X-axis format
controls.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43515&comment_hash=6faf537094c614fe46459b822356cbc59f52d5f0d6e4cf691cf716a04a17ca32&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43515&comment_hash=6faf537094c614fe46459b822356cbc59f52d5f0d6e4cf691cf716a04a17ca32&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
