bito-code-review[bot] commented on PR #43458:
URL: https://github.com/apache/superset/pull/43458#issuecomment-5412654802
<!-- Bito Reply -->
The flagged issue is correct. The access-denial path in the Explore page
component initiates a metadata request without utilizing the component's abort
signal, which can lead to stale state updates if the component unmounts before
the request completes.
To resolve this, you should pass the `controller.signal` to the request and
verify `controller.signal.aborted` before dispatching the result. Here is a
concise implementation:
```typescript
// Inside the request completion handler
const result = await fetchMetadata({ signal: controller.signal });
if (!controller.signal.aborted) {
dispatch(hydrateExplore(result));
}
```
I have checked the PR comments, and there are no other pending review
comments to address. Would you like me to perform any further analysis on this
PR?
**superset-frontend/src/pages/Chart/index.tsx**
```
const result = await fetchMetadata({ signal: controller.signal });
if (!controller.signal.aborted) {
dispatch(hydrateExplore(result));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
