sadpandajoe commented on code in PR #43458:
URL: https://github.com/apache/superset/pull/43458#discussion_r3874287485
##########
superset-frontend/src/pages/Chart/index.tsx:
##########
@@ -228,13 +228,11 @@ export default function ExplorePage() {
t('Failed to load chart data.');
dispatch(addDangerToast(errorMesage));
- if (err.extra?.datasource) {
+ if (err.extra?.is_access_denial) {
Review Comment:
During a rolling deploy, this new frontend can call an older API pod that
still returns the established `datasource`/`datasource_name` payload without
`is_access_denial`; this guard then takes the plain-error path and removes the
request-access UI. Could we retain a legacy discriminator here without
rendering the dataset name until the backend rollout is complete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
