bito-code-review[bot] commented on PR #43524: URL: https://github.com/apache/superset/pull/43524#issuecomment-5415357606
<!-- Bito Reply --> The flagged issue regarding a potential null pointer when `previousJwtSecret` is null is valid. To resolve this, you should ensure the configuration is normalized to an empty string if it is null or undefined before it is used in the filter. Here is a concise fix for the configuration loading logic: ```typescript // Ensure previousJwtSecret is a string, defaulting to an empty string if null/undefined config.previousJwtSecret = config.previousJwtSecret || ''; ``` I have checked the PR comments and there are no other actionable suggestions in the provided context. Would you like me to fetch all comments to validate and implement fixes for any remaining issues? **superset-websocket/src/index.ts** ``` config.previousJwtSecret = config.previousJwtSecret || ''; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
