codeant-ai-for-open-source[bot] commented on code in PR #43524:
URL: https://github.com/apache/superset/pull/43524#discussion_r3856332887
##########
superset-websocket/src/index.ts:
##########
@@ -489,17 +499,35 @@ export const subscribeToChannels = async ():
Promise<void> => {
/**
* Verify and parse a realtime JWT cookie from an HTTP request.
*/
+const verifyRealtimeJwt = (token: string): RealtimeJwtPayload => {
+ let lastError: unknown;
+ const acceptedSecrets = [opts.jwtSecret, opts.previousJwtSecret].filter(
+ secret => secret.length > 0,
+ );
Review Comment:
**Suggestion:** Configuration loaded from JSON is not runtime-validated, so
a null `previousJwtSecret` bypasses the optional startup check and then causes
every upgrade attempt to throw when the filter accesses `secret.length`.
Normalize non-string values to an empty secret or reject the configuration
before requests are handled. [null pointer]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ All WebSocket upgrades fail with malformed rotation configuration.
- ❌ Realtime browser updates cannot establish socket connections.
- ⚠️ Polling remains available as the documented correctness backstop.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f7bdede2f0bd47a392fbb36b1499c2ff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f7bdede2f0bd47a392fbb36b1499c2ff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-websocket/src/index.ts
**Line:** 504:506
**Comment:**
*Null Pointer: Configuration loaded from JSON is not runtime-validated,
so a null `previousJwtSecret` bypasses the optional startup check and then
causes every upgrade attempt to throw when the filter accesses `secret.length`.
Normalize non-string values to an empty secret or reject the configuration
before requests are handled.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43524&comment_hash=c5e30e78a0ebc6907d2cf2a0e95d4dbd76886783fce04b65e2a3920bb650ca67&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43524&comment_hash=c5e30e78a0ebc6907d2cf2a0e95d4dbd76886783fce04b65e2a3920bb650ca67&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
