rusackas commented on code in PR #43501:
URL: https://github.com/apache/superset/pull/43501#discussion_r3856703470
##########
superset/db_engine_specs/cockroachdb.py:
##########
@@ -44,7 +44,7 @@ class CockroachDbEngineSpec(PostgresEngineSpec):
DatabaseCategory.TRADITIONAL_RDBMS,
DatabaseCategory.OPEN_SOURCE,
],
- "pypi_packages": ["cockroachdb"],
+ "pypi_packages": ["sqlalchemy-cockroachdb"],
Review Comment:
Good catch. `sqlalchemy-cockroachdb` only depends on SQLAlchemy, not a DBAPI
driver -- pinned `psycopg2-binary` alongside it so the extra actually connects.
##########
pyproject.toml:
##########
@@ -142,7 +142,13 @@ bigquery = [
"google-cloud-bigquery>=3.42.3",
]
clickhouse = ["clickhouse-connect>=1.7.1, <2.0"]
-cockroachdb = ["cockroachdb>=0.3.5, <0.4"]
+# The `cockroachdb` PyPI package (last released 2021) is abandoned and its
+# SQLAlchemy dialect cannot even import under SQLAlchemy 2.0 (it references
+# sqlalchemy.dialects.postgresql.psycopg2.PGCompiler_psycopg2, removed in
+# 2.0). sqlalchemy-cockroachdb is the actively maintained replacement,
+# already linked from CockroachDbEngineSpec.metadata's docs_url, and
+# registers the same `cockroachdb` SQLAlchemy dialect entry point.
+cockroachdb = ["sqlalchemy-cockroachdb>=2.0.0, <3"]
Review Comment:
Confirmed -- verified against the PyPI metadata, no DBAPI driver in its
deps. Pinned `psycopg2-binary==2.9.12` alongside it, matching the `postgres`
extra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
