rusackas commented on code in PR #43501:
URL: https://github.com/apache/superset/pull/43501#discussion_r3858270437
##########
superset/db_engine_specs/cockroachdb.py:
##########
@@ -44,7 +44,7 @@ class CockroachDbEngineSpec(PostgresEngineSpec):
DatabaseCategory.TRADITIONAL_RDBMS,
DatabaseCategory.OPEN_SOURCE,
],
- "pypi_packages": ["cockroachdb"],
+ "pypi_packages": ["sqlalchemy-cockroachdb"],
Review Comment:
Good catch, but that JSON is a generated artifact, nothing in CI regenerates
it automatically. This branch also predates a docs restructuring on `master`
(`docs/docs/databases/supported` is gone there), so running the generator here
produces a much bigger diff unrelated to this fix. The source metadata is
already correct, I'd rather leave the artifact refresh for a real docs pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
