rusackas commented on code in PR #43346: URL: https://github.com/apache/superset/pull/43346#discussion_r3868529106
########## superset-frontend/plugins/plugin-chart-echarts/src/Butterfly/constants.ts: ########## @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + DEFAULT_LEGEND_FORM_DATA, + DEFAULT_TITLE_FORM_DATA, +} from '../constants'; +import { defaultXAxis } from '../defaults'; + +export const DEFAULT_FORM_DATA = { + ...DEFAULT_LEGEND_FORM_DATA, + ...DEFAULT_TITLE_FORM_DATA, + xAxisLabelRotation: defaultXAxis.xAxisLabelRotation, Review Comment: Not a regression, checked it against `Histogram` and `Waterfall`, both use the same shared `showValueControl` (default false) with no override in their own `constants.ts` either. Dropping the override here just brings Butterfly in line with them, and fixes the mismatch codeant flagged in the thread above rather than reintroducing it. Resolving both. ########## superset-frontend/plugins/plugin-chart-echarts/src/Butterfly/constants.ts: ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + DEFAULT_LEGEND_FORM_DATA, + DEFAULT_TITLE_FORM_DATA, +} from '../constants'; +import { defaultXAxis } from '../defaults'; + +export const DEFAULT_FORM_DATA = { + ...DEFAULT_LEGEND_FORM_DATA, + ...DEFAULT_TITLE_FORM_DATA, + showValue: true, Review Comment: This is fixed as of the current state, the override's gone now so the checkbox and the rendered chart agree (both default to no value labels), matching how `Histogram`/`Waterfall` handle the same shared control. Resolving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
