SBIN2010 commented on PR #43346: URL: https://github.com/apache/superset/pull/43346#issuecomment-5463018511
> LGTM. Chased down bito's regression callout on `showValue` and it's a false alarm, `Histogram` and `Waterfall` use the same shared `showValueControl` (default false) with no override either, so dropping it actually brings Butterfly in line and fixes the mismatch codeant flagged earlier in the same thread. Replied and resolved both. > > One small thing if you don't mind: `Butterfly/index.ts` still has `thumbnail: ''`, other plugins like Waterfall ship a real image for that. Not a blocker, just nice to have before merge. I’ll add thumbnail in the next PR, as well as cross-filtering and drill-to-detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
