sadpandajoe commented on code in PR #43169:
URL: https://github.com/apache/superset/pull/43169#discussion_r3870873687
##########
superset/app.py:
##########
@@ -242,4 +242,12 @@ def __call__(
environ["PATH_INFO"] = original_path_info[len(self.app_root) :]
environ["SCRIPT_NAME"] = self.app_root
return self.wsgi_app(environ, start_response)
+ if original_path_info == "/static" or
original_path_info.startswith("/static/"):
Review Comment:
With `SUPERSET_APP_ROOT=/static`, `/static/assets/...` matches the app-root
branch above this one first, which strips `/static` and sends `/assets/...` to
Flask; the static route then still 404s and this passthrough is unreachable.
Since the documented prefix contract only requires a leading slash, should
`/static` be rejected as a reserved app root or handled before the prefix
rewrite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
